Bug 260074

Summary:	Updates special case for flex-box emulating webkit-box
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Layout and Rendering	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	bfulgham, sgill26, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	BrowserCompat, InRadar, WPTImpact
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2023-08-11 10:12:26 PDT

Hi Team,

Came across another potential merge:

Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/1874250

Failing Test Case: https://wpt.fyi/results/compat/webkit-box-fieldset.html?label=experimental&label=master&aligned

WPT Live Link: http://wpt.live/compat/webkit-box-fieldset.html

In local build, doing following change leads to test progressing. So I think it is good win.

Thanks!

Comment 1 Ahmad Saleem 2023-08-11 10:29:13 PDT

Expected to fail, but passed: (2)
  imported/w3c/web-platform-tests/compat/webkit-box-fieldset.html
  imported/w3c/web-platform-tests/compat/webkit-box-rtl-flex.html


Regressions: Unexpected text-only failures (1)
  imported/w3c/web-platform-tests/compat/webkit-box-vertically-centered.html [ Failure ]

____

While running it on 'Compat' directory of WPT test cases.

Comment 2 Radar WebKit Bug Importer 2023-08-18 10:13:14 PDT

<rdar://problem/114094538>

Comment 3 Ahmad Saleem 2023-08-27 03:14:27 PDT

Tried this but didn't work:

if ((parent()->isDeprecatedFlexibleBox() || (parent()->isFlexibleBox() && (parent()->style().display() == DisplayType::Box ||  parent()->style().display() == DisplayType::InlineBox))) && (parent()->style().boxOrient() == BoxOrient::Horizontal || parent()->style().boxAlign() != BoxAlignment::Stretch))