Bug 260081
| Summary: | [css-flex][baseline-alignment] RenderFlexibleBox getBaselineChild needs to take into consideration flex line structure | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sammy Gill <sgill26> |
| Component: | Layout and Rendering | Assignee: | Sammy Gill <sgill26> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sammy Gill
https://drafts.csswg.org/css-flexbox-1/#flex-baselines
The current implementation of getBaselineChild does not take into consideration the writing mode or flex direction when determining which flex item to use for the flex container's baseline. This leads to many failures in the css/css-flexbox/alignment/flex-align-baseline-flex-* WPT tests. This bugzilla issue should serve as an umbrella for all of the incremental patches that will be added to rework the function implementation to more closely align to the spec.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/113765715>
Sammy Gill
Renaming the bug to mention that we should be using the flex line structure instead since that's really the central issue in the code
Sammy Gill
We ended up fixing the bugs that this was targeting in different patches so this is no longer needed