Bug 260103

Summary:	REGRESSION(266850@main): imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_document_cookie.https.window.html is a consistent failure.
Product:	WebKit	Reporter:	rupin
Component:	WebKit API	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ben_schwartz, cdumez, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	258504

Description rupin 2023-08-11 15:29:20 PDT

imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_document_cookie.https.window.html is flaky

Comment 1 Radar WebKit Bug Importer 2023-08-18 15:30:13 PDT

<rdar://problem/114112210>

Comment 2 Ben Schwartz 2023-10-17 15:39:07 PDT

imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_document_cookie.https.window.html

This test is a consistent text failure on wk2.

HISTORY:

https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcookie-store%2Fchange_eventhandler_for_document_cookie.https.window.html

TEXT DIFF:

 PASS document.cookie set/overwrite/delete observed by CookieStore
 PASS CookieStore set/overwrite/delete observed by document.cookie
 FAIL CookieStore agrees with document.cookie on encoding non-ASCII cookies assert_equals: Cookie we wrote using document.cookie in cookie jar expected (string) "DOCUMENT-ðŸª=ðŸ”µ" but got (undefined) undefined
-PASS document.cookie agrees with CookieStore on encoding non-ASCII cookies
+FAIL document.cookie agrees with CookieStore on encoding non-ASCII cookies assert_equals: Empty cookie jar after CookieStore delete expected (undefined) undefined but got (string) "DOCUMENT-ðŸª=ðŸ”µ"
 
DIFF URL:

https://build.webkit.org/results/Apple-Sonoma-Release-AppleSilicon-WK2-Tests/269423@main%20(319)/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_document_cookie.https.window-pretty-diff.html

REPRODUCIBILITY:

I was able to reproduce this issue on macOS Ventura (13.6, 22G120/arm64) ToT using the following command:

run-webkit-tests -v --iterations 10 --exit-after-n-failures 1 imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_document_cookie.https.window.html

REGRESSION:

The flakiness dashboard indicates a potential regression point at 266850@main. Changes at this point appear to be directly related to this issue and are likely what caused the failure.

Comment 3 Chris Dumez 2023-10-18 10:31:49 PDT

Pull request: https://github.com/WebKit/WebKit/pull/19235

Comment 4 EWS 2023-10-18 22:00:01 PDT

Committed 269503@main (8572ca9d273c): <https://commits.webkit.org/269503@main>

Reviewed commits have been landed. Closing PR #19235 and removing active labels.