Bug 260111

Summary: [ Ventura+ wk1 Release ] http/wpt/workers/modules/dedicated-worker-import-csp.html is a near-constant failure.
Product: WebKit Reporter: Ben Schwartz <ben_schwartz>
Component: New BugsAssignee: youenn fablet <youennf>
Status: RESOLVED MOVED    
Severity: Normal CC: webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=260107
https://bugs.webkit.org/show_bug.cgi?id=264258

Description Ben Schwartz 2023-08-11 17:54:10 PDT 
http/wpt/workers/modules/dedicated-worker-import-csp.html

This test is a constant failure on macOS Ventura WK1 release.

HISTORY:

https://results.webkit.org/?suite=layout-tests&test=http%2Fwpt%2Fworkers%2Fmodules%2Fdedicated-worker-import-csp.html&recent=false&flavor=wk1&platform=mac&style=release

TEXT DIFF:

-FAIL worker-src 'self' directive should disallow cross origin static import. assert_array_equals: expected property 0 to be "ERROR" but got "export-on-load-script.js" (expected array ["ERROR"] got ["export-on-load-script.js"])
-PASS worker-src * directive should allow cross origin static import.
-FAIL script-src 'self' directive should disallow cross origin static import. assert_array_equals: expected property 0 to be "ERROR" but got "export-on-load-script.js" (expected array ["ERROR"] got ["export-on-load-script.js"])
-PASS script-src * directive should allow cross origin static import.
-PASS worker-src * directive should override script-src 'self' directive and allow cross origin static import.
-FAIL worker-src 'self' directive should override script-src * directive and disallow cross origin static import. assert_array_equals: expected property 0 to be "ERROR" but got "export-on-load-script.js" (expected array ["ERROR"] got ["export-on-load-script.js"])
-FAIL script-src 'self' directive should disallow cross origin dynamic import. assert_array_equals: expected property 0 to be "ERROR" but got "export-on-load-script.js" (expected array ["ERROR"] got ["export-on-load-script.js"])
-PASS script-src * directive should allow cross origin dynamic import.
-PASS worker-src 'self' directive should not take effect on dynamic import.
+PASS worker-src 'self' directive should disallow cross origin static import.
+FAIL worker-src * directive should allow cross origin static import. assert_array_equals: expected property 0 to be "export-on-load-script.js" but got "ERROR" (expected array ["export-on-load-script.js"] got ["ERROR"])
+PASS script-src 'self' directive should disallow cross origin static import.
+FAIL script-src * directive should allow cross origin static import. assert_array_equals: expected property 0 to be "export-on-load-script.js" but got "ERROR" (expected array ["export-on-load-script.js"] got ["ERROR"])
+FAIL worker-src * directive should override script-src 'self' directive and allow cross origin static import. assert_array_equals: expected property 0 to be "export-on-load-script.js" but got "ERROR" (expected array ["export-on-load-script.js"] got ["ERROR"])
+PASS worker-src 'self' directive should override script-src * directive and disallow cross origin static import.
+PASS script-src 'self' directive should disallow cross origin dynamic import.
+FAIL script-src * directive should allow cross origin dynamic import. assert_array_equals: expected property 0 to be "export-on-load-script.js" but got "ERROR" (expected array ["export-on-load-script.js"] got ["ERROR"])
+FAIL worker-src 'self' directive should not take effect on dynamic import. assert_array_equals: expected property 0 to be "export-on-load-script.js" but got "ERROR" (expected array ["export-on-load-script.js"] got ["ERROR"])
 
DIFF URL:

https://build.webkit.org/results/Apple-Ventura-Release-AppleSilicon-WK1-Tests/266816@main%20(4662)/http/wpt/workers/modules/dedicated-worker-import-csp-pretty-diff.html

REPRODUCTION:

I was able to unreproduce this bug on the reported platform (arm64).

REGRESSION:

There is no clear regression as this is a WPT test imported at 266801@main.
Comment 1 Radar WebKit Bug Importer 2023-08-11 17:54:34 PDT 
<rdar://problem/113780242>
Comment 2 Ben Schwartz 2023-08-11 18:10:03 PDT 
I have marked this test as a constant failure while this issue is investigated. (PR link: https://github.com/WebKit/WebKit/pull/16635)
Comment 3 EWS 2023-08-11 18:11:15 PDT 
Test gardening commit 266842@main (a86e80526246): <https://commits.webkit.org/266842@main>

Reviewed commits have been landed. Closing PR #16635 and removing active labels.
Comment 4 youenn fablet 2023-10-18 09:08:33 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19231
Comment 5 EWS 2023-10-19 11:26:12 PDT 
Committed 269538@main (19432c811205): <https://commits.webkit.org/269538@main>

Reviewed commits have been landed. Closing PR #19231 and removing active labels.
Comment 6 Ben Schwartz 2023-11-03 08:25:29 PDT 
Re-opening, as this issue was not resolved by the changes landed in 269538@main.

With this progression, there's an addition at the top of the text diff:

+CONSOLE MESSAGE: Importing a module script failed.
+CONSOLE MESSAGE: Importing a module script failed.
+CONSOLE MESSAGE: Importing a module script failed.
+CONSOLE MESSAGE: Importing a module script failed.
+CONSOLE MESSAGE: Importing a module script failed.
+CONSOLE MESSAGE: Importing a module script failed.
+CONSOLE MESSAGE: Importing a module script failed.

https://build.webkit.org/results/Apple-Sonoma-Release-AppleSilicon-WK1-Tests/270172@main%20(556)/http/wpt/workers/modules/dedicated-worker-import-csp-diff.txt
Comment 7 Ben Schwartz 2023-11-03 09:09:50 PDT 
Landing revised test expectation (changed to Ventura+, Pass/Failure)
Comment 8 EWS 2023-11-03 09:12:59 PDT 
Test gardening commit 270178@main (760493829076): <https://commits.webkit.org/270178@main>

Reviewed commits have been landed. Closing PR #19955 and removing active labels.
Comment 9 Ben Schwartz 2023-11-06 08:34:34 PST 
Closing, but issue not resolved. Continuing in bug #264258.