Bug 260126

Summary:	[IntersectionObserver] Fix some edge cases in parsing options
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	DOM	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, rniwa, webkit-bug-importer
Priority:	P2	Keywords:	BrowserCompat, InRadar, WPTImpact
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
URL:	http://wpt.live/intersection-observer/observer-attributes.html

Description Ahmad Saleem 2023-08-13 09:24:11 PDT

Hi Team,

This is just another Blink merge to fix IntersectionObserver bugs.

Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/2388706

WPT Live Link: http://wpt.live/intersection-observer/observer-attributes.html

WPT Test Case: https://wpt.fyi/results/intersection-observer/observer-attributes.html?label=master&label=experimental&aligned=

____

WebKit Source Changes:

First Line 159 >  tokenRange.consumeWhitespace();

Second Line 121 below:

if (thresholds.isEmpty())
        thresholds.append(0.f);

______

We are after above changes passing all tests.

Thanks!

Comment 1 EWS 2023-08-13 13:37:01 PDT

Committed 266856@main (0fcecf40e3a1): <https://commits.webkit.org/266856@main>

Reviewed commits have been landed. Closing PR #16648 and removing active labels.

Comment 2 Radar WebKit Bug Importer 2023-08-13 13:38:11 PDT

<rdar://problem/113826514>