Bug 260136

Summary: [web-animations] linear() probably does not work with transform and other accelerated properties
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, graouts, hi, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=240061

Description Antoine Quint 2023-08-14 03:47:17 PDT
I expect the changes made in 266196@main for bug 240061 are not dealing with accelerated animations. Indeed, CoreAnimation doesn’t have any native equivalent to linear() so we’ll have to either find something that matches and add code to translate to the CA-native primitive or expand KeyframeEffect::canBeAccelerated() to do something similar to what we do with steps(). I argue for the latter because with the work for threaded animation resolution support for linear() will be free and I think it’s not a good idea to add more CA-specific code.
Comment 1 Radar WebKit Bug Importer 2023-08-21 03:48:14 PDT
<rdar://problem/114185868>
Comment 2 Antoine Quint 2023-10-20 06:56:54 PDT
<rdar://114084978>
Comment 3 Antoine Quint 2023-10-20 07:17:01 PDT
Pull request: https://github.com/WebKit/WebKit/pull/19341
Comment 4 EWS 2023-10-20 14:39:01 PDT
Committed 269594@main (07b0116f3ef9): <https://commits.webkit.org/269594@main>

Reviewed commits have been landed. Closing PR #19341 and removing active labels.