Bug 260365

Summary:	Make VTTCue.size() from 'int' to 'double'
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Media	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	eric.carlson, jer.noble, webkit-bug-importer
Priority:	P2	Keywords:	BrowserCompat, InRadar, WPTImpact
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2023-08-17 15:16:48 PDT

Hi Team,

While going through WPT failures, I noticed that we are failing following test:

WPT Test Case: https://wpt.fyi/results/webvtt/api/VTTCue/size.html?label=experimental&label=master&aligned

WPT Live Link: http://wpt.live/webvtt/api/VTTCue/size.html

I started looking and noticed that in IDL file, we have it as double but in VTTCue.cpp and VTTCue.h, we have it as 'int', which is just whole number and on local build after changing it to 'double', it make us pass the following test.

Interface IDL Web-Spec: https://w3c.github.io/webvtt/#the-vttcue-interface

It is just to align with spec and start using 'double'.

Just raising so I can fix it.

Thanks!

Comment 1 Radar WebKit Bug Importer 2023-08-18 09:04:26 PDT

<rdar://problem/114089775>

Comment 2 EWS 2023-08-18 09:15:22 PDT

Committed 267041@main (b93351e6debe): <https://commits.webkit.org/267041@main>

Reviewed commits have been landed. Closing PR #16808 and removing active labels.