Bug 260390

Summary:	Don't allow form-feed (U+000C) as a WebVTT signature separator
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Media	Assignee:	Anne van Kesteren <annevk>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	destra, eric.carlson, jer.noble, karlcow, webkit-bug-importer
Priority:	P2	Keywords:	BrowserCompat, InRadar, WPTImpact
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	179370
Bug Blocks:

Description Ahmad Saleem 2023-08-18 09:42:17 PDT

Hi Team,

This is another Blink merge to get another WPT win.

Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/84007ecf0f27d2074c70955d43cc1743ee39980a

WPT Test Case Live Link: http://wpt.live/webvtt/parsing/file-parsing/signature-invalid.html

^ We fail two but this bug is about 'signature - formfeed'.

I have local patch for it to progress the above.

Web-Spec: https://w3c.github.io/webvtt/#webvtt-parser-algorithm

Just wanted to raise so we can fix it.

Thanks!

Comment 1 Radar WebKit Bug Importer 2023-08-18 18:36:03 PDT

<rdar://problem/114118340>

Comment 2 Karl Dubost 2023-08-20 18:21:22 PDT

Ahmad,
That seems like a low hanging fruit.

Comment 3 Anne van Kesteren 2023-09-07 22:29:38 PDT

Pull request: https://github.com/WebKit/WebKit/pull/17576

Comment 4 EWS 2023-10-20 23:05:51 PDT

Committed 269619@main (f98a7bee4cc3): <https://commits.webkit.org/269619@main>

Reviewed commits have been landed. Closing PR #17576 and removing active labels.