Bug 260454

Summary: [IFC] Add non-line-builder based minimum width computation
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
[fast-cq]Patch none

alan
Reported 2023-08-20 19:24:25 PDT
ssia
Attachments
Patch (9.29 KB, patch)
2023-08-20 19:30 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (9.29 KB, patch)
2023-08-21 11:00 PDT, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
[fast-cq]Patch (9.64 KB, patch)
2023-08-21 14:14 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2023-08-20 19:30:43 PDT
Created attachment 467352 [details] Patch
Radar WebKit Bug Importer
Comment 2 2023-08-20 19:30:57 PDT
<rdar://problem/114170752>
Antti Koivisto
Comment 3 2023-08-21 08:50:18 PDT
Comment on attachment 467352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467352&action=review > COMMIT_MESSAGE:8 > +(This is a 4x speedup on PerformanceTests/Layout/line-layout-preferred-width-break-all.html) Not even 10x. Sad. > Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp:39 > +static bool isEligibleForNonLineBuilderProcess(const RenderStyle& style) A new process?
alan
Comment 4 2023-08-21 11:00:45 PDT
Created attachment 467371 [details] Patch
alan
Comment 5 2023-08-21 14:14:24 PDT
Created attachment 467372 [details] [fast-cq]Patch
EWS
Comment 6 2023-08-21 19:56:55 PDT
Committed 267116@main (23014ddf9929): <https://commits.webkit.org/267116@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467372 [details].
Note You need to log in before you can comment on or make changes to this bug.