Bug 260454

Summary: [IFC] Add non-line-builder based minimum width computation
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
[fast-cq]Patch none

Description zalan 2023-08-20 19:24:25 PDT 
ssia
Comment 1 zalan 2023-08-20 19:30:43 PDT 
Created attachment 467352 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2023-08-20 19:30:57 PDT 
<rdar://problem/114170752>
Comment 3 Antti Koivisto 2023-08-21 08:50:18 PDT 
Comment on attachment 467352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467352&action=review

> COMMIT_MESSAGE:8
> +(This is a 4x speedup on PerformanceTests/Layout/line-layout-preferred-width-break-all.html)

Not even 10x. Sad.

> Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp:39
> +static bool isEligibleForNonLineBuilderProcess(const RenderStyle& style)

A new process?
Comment 4 zalan 2023-08-21 11:00:45 PDT 
Created attachment 467371 [details]
Patch
Comment 5 zalan 2023-08-21 14:14:24 PDT 
Created attachment 467372 [details]
[fast-cq]Patch
Comment 6 EWS 2023-08-21 19:56:55 PDT 
Committed 267116@main (23014ddf9929): <https://commits.webkit.org/267116@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467372 [details].