Bug 260693

Created attachment 467428 [details]
Patch

What is an opaque box?

Created attachment 467447 [details]
Patch

Comment on attachment 467447 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467447&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItem.h:39
> -    enum class Type : uint8_t {
> +    enum class Type : uint16_t {

I don't think this enum type needs to grow. uint8_t does fit 9 values.

(In reply to Antti Koivisto from comment #4)
> Comment on attachment 467447 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467447&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineItem.h:39
> > -    enum class Type : uint8_t {
> > +    enum class Type : uint16_t {
> 
> I don't think this enum type needs to grow. uint8_t does fit 9 values.
oh you are right, I was fixing some crash which ended up being the other enum and forgot to undo this.

Created attachment 467449 [details]
[fast-cq]Patch

Comment on attachment 467449 [details]
[fast-cq]Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467449&action=review

> COMMIT_MESSAGE:13
> +An opaque item:
> +  - does not introduce a soft wrap opportunity
> +  - does not participate in line breaking (zero logical width)
> +  - has the bidi level of 0xff
> +  - does not affect parent inline box/line box height
> +  - does not create display box

Can we have this comment in the code? It would be helpful for someone new to this code, especially if this is not a spec concept

(In reply to Tim Nguyen (:ntim) from comment #7)
> Comment on attachment 467449 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467449&action=review
> 
> > COMMIT_MESSAGE:13
> > +An opaque item:
> > +  - does not introduce a soft wrap opportunity
> > +  - does not participate in line breaking (zero logical width)
> > +  - has the bidi level of 0xff
> > +  - does not affect parent inline box/line box height
> > +  - does not create display box
> 
> Can we have this comment in the code? It would be helpful for someone new to
> this code, especially if this is not a spec concept
This will get clear when we start using this type for a particular box type (out-of-flow). That's a spec concept.

Committed 267327@main (b82a10b890c0): <https://commits.webkit.org/267327@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467449 [details].

<rdar://problem/114498075>