Bug 260695

Summary: Simplify Quirks for shouldSuppressAutocorrectionAndAutocapitalizationInHiddenEditableAreas
Product: WebKit Reporter: Karl Dubost <karlcow>
Component: New BugsAssignee: Karl Dubost <karlcow>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 17   
Hardware: Unspecified   
OS: Unspecified   

Description Karl Dubost 2023-08-24 21:53:06 PDT
Currently 

// rdar://49864669
bool Quirks::shouldSuppressAutocorrectionAndAutocapitalizationInHiddenEditableAreas() const
{
    if (!needsQuirks())
        return false;

    return shouldSuppressAutocorrectionAndAutocapitalizationInHiddenEditableAreasForHost(m_document->topDocument().url().host());
}

 is calling 

// docs.google.com rdar://49864669
static bool shouldSuppressAutocorrectionAndAutocapitalizationInHiddenEditableAreasForHost(StringView host)
{
#if PLATFORM(IOS_FAMILY)
    return equalLettersIgnoringASCIICase(host, "docs.google.com"_s);
#else
    UNUSED_PARAM(host);
    return false;
#endif
}

Probably this should be only one function.
Comment 1 Karl Dubost 2023-08-24 22:17:51 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17053
Comment 2 EWS 2023-08-25 11:30:25 PDT
Committed 267288@main (2ec1a7e6b1ca): <https://commits.webkit.org/267288@main>

Reviewed commits have been landed. Closing PR #17053 and removing active labels.