Bug 260702

Summary: Build fix after 160450@main by guarding showRenderTree
Product: WebKit Reporter: ChangSeok Oh <changseok>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   

Description ChangSeok Oh 2023-08-25 00:12:42 PDT
Adding a build flag, "-DLOG_DISABLED=0" breaks the build with the following messages.

/app/webkit/Source/WebCore/page/LocalFrameViewLayoutContext.cpp: In member function ‘void WebCore::LocalFrameViewLayoutContext::performLayout()’:
/app/webkit/Source/WebCore/page/LocalFrameViewLayoutContext.cpp:248:13: error: ‘showRenderTree’ was not declared in this scope
  248 |             showRenderTree(renderView());
      |             ^~~~~~~~~~~~~~                                                   
[1313/2437] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-767013ce-10.cpp.o
ninja: build stopped: subcommand failed.
Comment 1 EWS 2023-08-25 01:25:51 PDT
Committed 267268@main (9e05696bcb54): <https://commits.webkit.org/267268@main>

Reviewed commits have been landed. Closing PR #17060 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-08-25 01:26:15 PDT
<rdar://problem/114437045>