Bug 260742

Summary: REGRESSION (267279@main): [ macOS Debug ] ASSERTION FAILED: WebCore::MediaSource::completeSeek()::SeeksCallbackAggregator::SeeksCallbackAggregator
Product: WebKit Reporter: Karl Rackler <rackler>
Component: New BugsAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: jean-yves.avenard, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=260185
Attachments:
Description Flags
symbolicated-log none

Description Karl Rackler 2023-08-25 15:05:17 PDT
Created attachment 467442 [details]
symbolicated-log

Description:
fast/canvas/webgl/texImage2D-mse-flipY-false.html
fast/canvas/webgl/texImage2D-mse-flipY-true.html

2 fast/canvas/webgl/texImage2D-mse-flipY are a consistent crash on macOS ToT and since 267279@main.  
Commit <https://commits.webkit.org/267279@main> modified code for SeeksCallbackAggregator which is now causing the tests assertions on macOS debug.

This issue can be reproduced using command:
run-webkit-tests --debug --iterations=1   fast/canvas/webgl/texImage2D-mse-flipY-false.html

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=fast%2Fcanvas%2Fwebgl%2FtexImage2D-mse-flipY-false.html&test=fast%2Fcanvas%2Fwebgl%2FtexImage2D-mse-flipY-true.html&platform=mac&style=debug

Crash Log:
Thread 0 Crashed::   Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	       0x1377de6e0 WTFCrash
1   com.apple.WebCore             	       0x2840c7cd0 WTFCrashWithInfo(int, char const*, char const*, int)
2   com.apple.WebCore             	       0x28277d334 WebCore::MediaSource::completeSeek()::SeeksCallbackAggregator::SeeksCallbackAggregator(WTF::MediaTime, WebCore::MediaSource&, WTF::CompletionHandler<void (WTF::MediaTime const&)>&&)
3   com.apple.WebCore             	       0x28276d2e0 WebCore::MediaSource::completeSeek()::SeeksCallbackAggregator::SeeksCallbackAggregator(WTF::MediaTime, WebCore::MediaSource&, WTF::CompletionHandler<void (WTF::MediaTime const&)>&&)
4   com.apple.WebCore             	       0x28276d144 WebCore::MediaSource::completeSeek()
5   com.apple.WebCore             	       0x28276cd20 WebCore::MediaSource::seekToTarget(WebCore::SeekTarget const&, WTF::CompletionHandler<void (WTF::MediaTime const&)>&&)
Comment 1 Radar WebKit Bug Importer 2023-08-25 15:08:44 PDT
<rdar://problem/114472398>
Comment 2 EWS 2023-08-25 15:25:24 PDT
Test gardening commit 267302@main (fbe822a7df67): <https://commits.webkit.org/267302@main>

Reviewed commits have been landed. Closing PR #17085 and removing active labels.
Comment 3 Jean-Yves Avenard [:jya] 2023-08-25 18:48:46 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17096
Comment 4 EWS 2023-08-25 20:02:36 PDT
Committed 267314@main (f005b556a611): <https://commits.webkit.org/267314@main>

Reviewed commits have been landed. Closing PR #17096 and removing active labels.