| Summary: | AX: Implement test_driver_internal.{get_computed_role, get_computed_label} | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tyler Wilcock <tyler_w> | ||||||||||||||
| Component: | Accessibility | Assignee: | Tyler Wilcock <tyler_w> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, clopez, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer, youennf | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | Other | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Tyler Wilcock
2023-08-25 19:01:27 PDT
Created attachment 467448 [details]
Patch
Created attachment 467450 [details]
Patch
Created attachment 467451 [details]
Patch
Created attachment 467453 [details]
Patch
Comment on attachment 467453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467453&action=review > Source/WebCore/testing/Internals.cpp:7161 > +AccessibilityObject* Internals::axObjectFor(Element& element) const is this style of naming used in WebKit? I would have expected the name to be axObjectForElement > Source/WebCore/testing/Internals.cpp:7198 > + return element.renderer() || !element.rendererIsNeeded(*computedStyle); we've already checked element.renderer() above. do we need to check it here too? Created attachment 467459 [details]
Patch
Created attachment 467460 [details]
Patch
Committed 267364@main (33b030f32890): <https://commits.webkit.org/267364@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467460 [details]. |