Bug 260766
| Summary: | Use 'ScrollSetting' enum in 'VTTRegion.idl' align with IDL Spec | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Media | Assignee: | Anne van Kesteren <annevk> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
SSIA
As per Web-Spec: https://www.w3.org/TR/webvtt1/#the-vttregion-interface
In Web-Spec, we have:
enum ScrollSetting { "" /* none */, "up" };
and then have changed below as well:
attribute [AtomString] DOMString scroll; <- this to: attribute ScrollSetting scroll;
_
Just raising, so we can fix it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/114859668>
Anne van Kesteren
Pull request: https://github.com/WebKit/WebKit/pull/17626
EWS
Committed 267842@main (48210b2e0db4): <https://commits.webkit.org/267842@main>
Reviewed commits have been landed. Closing PR #17626 and removing active labels.