Bug 260776

Summary: [IFC] Use opaque InlineItem to compute out-of-flow static position
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description zalan 2023-08-27 09:52:13 PDT 
ssia
Comment 1 zalan 2023-08-27 09:57:32 PDT 
Created attachment 467454 [details]
Patch
Comment 2 zalan 2023-08-27 19:25:29 PDT 
Created attachment 467455 [details]
Patch
Comment 3 zalan 2023-08-28 12:37:39 PDT 
Created attachment 467468 [details]
Patch
Comment 4 zalan 2023-08-28 15:14:34 PDT 
Created attachment 467470 [details]
Patch
Comment 5 zalan 2023-08-28 15:49:23 PDT 
Created attachment 467472 [details]
Patch
Comment 6 zalan 2023-08-28 19:36:25 PDT 
Created attachment 467476 [details]
Patch
Comment 7 zalan 2023-08-28 20:34:26 PDT 
Created attachment 467478 [details]
Patch
Comment 8 Antti Koivisto 2023-08-28 22:54:27 PDT 
Comment on attachment 467478 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467478&action=review

> COMMIT_MESSAGE:6
> +Let's replace existing out-of-flow handling with using opaque inline items instead.

Nice!

> Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:884
> +    auto formattingContext = this->formattingContext();

Does this purposefully create a copy of the formatting context?
Comment 9 zalan 2023-08-29 07:14:26 PDT 
(In reply to Antti Koivisto from comment #8)
> Comment on attachment 467478 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467478&action=review
> 
> > COMMIT_MESSAGE:6
> > +Let's replace existing out-of-flow handling with using opaque inline items instead.
> 
> Nice!
> 
> > Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:884
> > +    auto formattingContext = this->formattingContext();
> 
> Does this purposefully create a copy of the formatting context?
certainly not! good catch!
Comment 10 zalan 2023-08-29 07:20:33 PDT 
Created attachment 467481 [details]
Patch
Comment 11 zalan 2023-08-30 07:31:05 PDT 
Created attachment 467491 [details]
Patch
Comment 12 EWS 2023-08-30 09:29:17 PDT 
Committed 267456@main (bac664c02d19): <https://commits.webkit.org/267456@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467491 [details].
Comment 13 Radar WebKit Bug Importer 2023-08-30 09:30:17 PDT 
<rdar://problem/114705938>