Bug 260903

Summary: [IFC][Coverage] Remove margin-trim check
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, clopez, ews-watchlist, koivisto, ntim, simon.fraser, webkit-bug-importer, youennf, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+, ews-feeder: commit-queue-
[fast-cq]Patch none

alan
Reported 2023-08-30 07:33:04 PDT
it does not apply.
Attachments
Patch (2.81 KB, patch)
2023-08-30 07:41 PDT, alan 		koivisto: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
[fast-cq]Patch (8.07 KB, patch)
2023-09-06 20:45 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2023-08-30 07:41:28 PDT
Created attachment 467492 [details] Patch
alan
Comment 2 2023-08-30 08:58:56 PDT
Comment on attachment 467492 [details] Patch Apparently float-only cases need some work.
Radar WebKit Bug Importer
Comment 3 2023-09-06 07:34:14 PDT
<rdar://problem/115055358>
alan
Comment 4 2023-09-06 20:45:42 PDT
Created attachment 467579 [details] [fast-cq]Patch
EWS Watchlist
Comment 5 2023-09-06 20:51:23 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Tim Nguyen (:ntim)
Comment 6 2023-09-06 21:19:47 PDT
Comment on attachment 467579 [details] [fast-cq]Patch If the WPT changes need to be done upstream, please run `export-w3c-test-changes -b 260903 -g HEAD -c --no-linter` to export them, otherwise they'll be lost at the next import.
alan
Comment 7 2023-09-07 06:28:18 PDT
(In reply to Tim Nguyen (:ntim) from comment #6) > Comment on attachment 467579 [details] > [fast-cq]Patch > > If the WPT changes need to be done upstream, please run > `export-w3c-test-changes -b 260903 -g HEAD -c --no-linter` to export them, > otherwise they'll be lost at the next import. they don't (pending on float margin trim feature removal)
EWS
Comment 8 2023-09-07 06:30:38 PDT
Committed 267725@main (f70985fd068f): <https://commits.webkit.org/267725@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467579 [details].
Note You need to log in before you can comment on or make changes to this bug.