Bug 261022
| Summary: | [TextureMapper] Move filter specific code from BitmapTextureGL to TextureMapperGL | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Akihiro Kiuchi <aki.develop8128> |
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | fujii.hironori, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 231653 | ||
Akihiro Kiuchi
This is a preparation refactoring for https://bugs.webkit.org/show_bug.cgi?id=231653.
To fix the issue above, we have to change the number of passes needed to do blur filtering according to the standard deviation of the blur.
Now the number of passes for each filter is specified in BitmapTextureGL.cpp but other parameters regarding filtering such as shader options are specified in TextureMapperGL.cpp, which leads to the inconsistency and low readability.
My suggestion is to move the loop of passes, written in BitmapTextureGL.cpp for now, to TextureMapperGL.cpp
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Fujii Hironori
PR https://github.com/WebKit/WebKit/pull/17335
EWS
Committed 267599@main (499bdf98d4a7): <https://commits.webkit.org/267599@main>
Reviewed commits have been landed. Closing PR #17335 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/114912332>