| Summary: | [IFC][line-clamp] Add support for "more info" type of trailing link handling | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 274308 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
zalan
2023-09-01 06:06:15 PDT
Created attachment 467516 [details]
Patch
Created attachment 467518 [details]
Patch
Created attachment 467520 [details]
Patch
Created attachment 467521 [details]
Patch
Comment on attachment 467521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467521&action=review > Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp:414 > + // This is link-box type of line clamping where we check if the inline content ends in a link > + // and move such link content next to the clamped line's trailing ellispsis. > + // > + // first line > + // second line is clamped... more info > + // > + // where "more info" is a link and it comes from the end of the inline content (normally invisible due to block direction clamping) > + // This is only to match legacy line clamping behavior (and not a block-ellispsis: <string> implementation) > + // It supports horizontal, left-to-right content only where the link inline box has (non-split) text content and when > + // the link content ('more info') fits the clamped line. It would be nice to give some background about what this is for and why this is still needed (and also that it is triggered by -webkit-line-clamp). Created attachment 467527 [details]
Patch
Committed 267588@main (bf48ac60d4bb): <https://commits.webkit.org/267588@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467527 [details]. |