Bug 261054

Summary:	REGRESSION(267516@main): [ macOS ] editing/selection/context-menu-text-selection-lookup.html is a constant text failure.
Product:	WebKit	Reporter:	Ben Schwartz <ben_schwartz>
Component:	Text	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	mmaxfield, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=259373 https://bugs.webkit.org/show_bug.cgi?id=261052 https://bugs.webkit.org/show_bug.cgi?id=261041 https://bugs.webkit.org/show_bug.cgi?id=261048

Description Ben Schwartz 2023-09-01 17:00:08 PDT

editing/selection/context-menu-text-selection-lookup.html

This test is a constant failure on all versions of macOS.

HISTORY:

https://results.webkit.org/?suite=layout-tests&test=editing%2Fselection%2Fcontext-menu-text-selection-lookup.html

TEXT DIFF:

 This test checks that triggering the context menu selects/doesn't select using surround text as context (as platform-appropriate).
 
 New York
-FAILURE: We expected New York, but we got New.
 SUCCESS
 SUCCESS
+SUCCESS

DIFF URL:

https://build.webkit.org/results/Apple-Ventura-Release-AppleSilicon-WK2-Tests/267553%40main%20(4741)/editing/selection/context-menu-text-selection-lookup-pretty-diff.html

REPRODUCIBILITY:

I was able to reproduce this bug on macOS Ventura (13.5, 22G74/arm64) ToT using the following command:

run-webkit-tests --clobber-old-results --verbose editing/selection/context-menu-text-selection-lookup.html

REGRESSION:

I was able to identify a clear regression point at 267516@main, as the issue did not reproduce at 267515@main and the test was constantly passing before this point.

NOTE:

It appears this test itself needs to be re-baselined, as there is a trivial difference in the test expectation ("New" instead of "New York") that is likely outdated.

Comment 1 Radar WebKit Bug Importer 2023-09-01 17:00:34 PDT

<rdar://problem/114848071>

Comment 2 EWS 2023-09-01 17:33:44 PDT

Test gardening commit 267571@main (607f89ab88cf): <https://commits.webkit.org/267571@main>

Reviewed commits have been landed. Closing PR #17363 and removing active labels.

Comment 3 Ben Schwartz 2023-09-01 17:34:45 PDT

Closing, as issue verified resolved after landed changes.