Bug 261067
| Summary: | Check for NaN when creating a DelayNode for WebAudio | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Web Audio | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, karlcow, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar |
| Version: | Safari 16 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
I think it would be good to merge this and also update 'Layout Test' for 'NaN' check.
Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/c8c4a710be6292a220177fef0c3f1c7c7853d062
WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/Modules/webaudio/DelayNode.cpp#55 & https://searchfox.org/wubkat/source/Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp#75
___
Test Output:
PASS context.createDelay(NaN) threw exception TypeError: The provided value is non-finite.
___
Just wanted to raise to get opinion whether we should merge it or not.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Karl Dubost
https://wpt.fyi/results/webaudio/the-audio-api/the-delaynode-interface?label=master&label=experimental&aligned&q=delaynode%20
Karl Dubost
https://searchfox.org/wubkat/rev/68e96f24aae90f5a0a5e0c56c932c93616766cc7/Source/WebCore/Modules/webaudio/DelayNode.cpp#50-67
Maybe it's already checked in some ways.
EWS
Committed 267650@main (5736f9dd89ea): <https://commits.webkit.org/267650@main>
Reviewed commits have been landed. Closing PR #17379 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/115008784>