Bug 261117
| Summary: | SVGStyleElement::attributeChanged does much less than HTMLStyleElement | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | ahmad.saleem792, sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Anne van Kesteren
I haven't verified if that is the reason for the failure in https://wpt.fyi/results/html/semantics/document-metadata/the-style-element/style_type_svg.svg, but it undoubtedly will result in other failures. Perhaps these elements should share more logic somehow.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
I fixed it.
https://commits.webkit.org/266744@main
Anne van Kesteren
Ah, I was wondering why the current code would not pass that test. I think what will end up failing is something like this:
<svg:style type="blah">
body { color:lime }
</svg:style>
document.querySelector("style").type = "text/css"
because there is nothing in SVGStyleElement::attributeChanged to trigger style sheet changes. Setting the type doesn't do much on its own. HTMLStyleElement::attributeChanged does seem to account for that.
Radar WebKit Bug Importer
<rdar://problem/115293825>
Said Abou-Hallawa
*** This bug has been marked as a duplicate of bug 259979 ***