Bug 261163

Summary:	Simplify the CodeGeneratorExtensions.pm generated code for the most common optional argument case
Product:	WebKit	Reporter:	Timothy Hatcher <timothy>
Component:	WebKit Extensions	Assignee:	Timothy Hatcher <timothy>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	timothy, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified

Timothy Hatcher

Reported 2023-09-05 09:17:44 PDT

The generator outputs complex argument handling code in all cases, when it can be simplified for common 2 and 3 argument cases when the last argument is optional.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-09-05 09:17:52 PDT

<rdar://problem/114986995>

Timothy Hatcher

Comment 2 2023-09-05 10:31:36 PDT

Pull request: https://github.com/WebKit/WebKit/pull/17446

EWS

Comment 3 2023-09-06 14:50:07 PDT

Committed 267695@main (77ea37f47bee): <https://commits.webkit.org/267695@main> Reviewed commits have been landed. Closing PR #17446 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.