Bug 261213

Summary: REGRESSION(267655@main): inspector/sampling-profiler/many-call-frames.html is a constant text failure.
Product: WebKit Reporter: Ben Schwartz <ben_schwartz>
Component: Web InspectorAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Normal CC: ashvayka, inspector-bugzilla-changes, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=260487

Description Ben Schwartz 2023-09-06 10:50:40 PDT
inspector/sampling-profiler/many-call-frames.html

This test is a constant failure on all platforms.

HISTORY:

https://results.webkit.org/?suite=layout-tests&test=inspector%2Fsampling-profiler%2Fmany-call-frames.html

TEXT DIFF:

+CONSOLE MESSAGE: TypeError: Can't declare global function 'top': property must be either configurable or both writable and enumerable
+ALERT: Failed to send test() because it is not a function.
 
-== Running test suite: ScriptProfiler.Samples.ManyCallFrames
--- Running test case: Sampling Profiler sourceURL directive.
-PASS: Should have seen stacktrace:
-[
-  {
-    "name": "top"
-  },
-  {
-    "name": "g"
-  },
-  {
-    "name": "f"
-  },
-  {
-    "name": "e"
-  },
-  {
-    "name": "d"
-  },
-  {
-    "name": "c"
-  },
-  {
-    "name": "b"
-  },
-  {
-    "name": "a"
-  },
-  {
-    "name": "runFor"
-  }
-]
-

DIFF URL:

https://build.webkit.org/results/Apple-Ventura-Release-AppleSilicon-WK2-Tests/267668%40main%20(4797)/inspector/sampling-profiler/many-call-frames-pretty-diff.html

REPRODUCIBILITY:

I was able to reproduce this bug on macOS Ventura (13.5, 22G74/arm64) using the following command:

rwt --clobber-old-results --verbose inspector/sampling-profiler/many-call-frames.html

REGRESSION:

There seems to be a clear regression point at 267655@main, as the issue began constantly failing then (issue did not reproduce at 267654@main).
Comment 1 Radar WebKit Bug Importer 2023-09-06 10:50:49 PDT
<rdar://problem/115064790>
Comment 2 EWS 2023-09-06 11:00:52 PDT
Test gardening commit 267682@main (22c04c69749e): <https://commits.webkit.org/267682@main>

Reviewed commits have been landed. Closing PR #17491 and removing active labels.
Comment 3 Alexey Shvayka 2023-09-06 12:06:26 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17495
Comment 4 EWS 2023-09-06 19:28:23 PDT
Committed 267711@main (ff020b48aec1): <https://commits.webkit.org/267711@main>

Reviewed commits have been landed. Closing PR #17495 and removing active labels.