| Summary: | Add a WKWebPushToolMain for webpushtool to use | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> |
| Component: | WebKit Misc. | Assignee: | Brady Eidson <beidson> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
Brady Eidson
2023-09-06 15:23:27 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17507 Committed 267714@main (a12bd8488608): <https://commits.webkit.org/267714@main> Reviewed commits have been landed. Closing PR #17507 and removing active labels. This seems to break my command line build (USE_WORKSPACE=NO make r). Committed 267732@main (e0822d5cf7c5): <https://commits.webkit.org/267732@main> Reviewed commits have been landed. Closing PR #17544 and removing active labels. Re-opening for pull request https://github.com/WebKit/WebKit/pull/17553 This broke production builds (And presumably the specific type of command line build Youenn did) because there were still some things left in the "webpushtool" target in the Xcode project. Clearing them out so it's just the .cpp that calls the new stub seems to have fixed it 👍 Committed 267755@main (d222062cd5d9): <https://commits.webkit.org/267755@main> Reviewed commits have been landed. Closing PR #17553 and removing active labels. |