Bug 261237

Summary: AX: title-attribute-used-as-last-resort fails in ITM
Product: WebKit Reporter: Joshua Hoffman <jhoffman23>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Joshua Hoffman 2023-09-06 15:27:55 PDT 
When run in isolated tree mode, the Mac/title-attribute-used-as-last-resort.html test fails.
Comment 1 Radar WebKit Bug Importer 2023-09-06 15:28:03 PDT 
<rdar://problem/115079675>
Comment 2 Joshua Hoffman 2023-09-06 16:23:32 PDT 
Created attachment 467577 [details]
Patch
Comment 3 Tyler Wilcock 2023-09-07 00:00:55 PDT 
Comment on attachment 467577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467577&action=review

> LayoutTests/accessibility/mac/title-attribute-used-as-last-resort.html:28
> +        document.getElementById("link2").focus()

Looks like this patch removes some semicolons after .focus() calls, but our code style prefers to have them.
Comment 4 Joshua Hoffman 2023-09-07 09:00:20 PDT 
Comment on attachment 467577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467577&action=review

>> LayoutTests/accessibility/mac/title-attribute-used-as-last-resort.html:28
>> +        document.getElementById("link2").focus()
> 
> Looks like this patch removes some semicolons after .focus() calls, but our code style prefers to have them.

ah yep—I'll fix that!
Comment 5 Joshua Hoffman 2023-09-07 09:07:14 PDT 
Created attachment 467588 [details]
Patch
Comment 6 EWS 2023-09-07 16:21:07 PDT 
Committed 267757@main (93abe637e908): <https://commits.webkit.org/267757@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467588 [details].