Bug 261240

Summary:	[Xcode] Track "Additional Resources" copied from WebKitAdditions
Product:	WebKit	Reporter:	Elliott Williams <emw>
Component:	Tools / Tests	Assignee:	Elliott Williams <emw>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Elliott Williams

Reported 2023-09-06 16:27:01 PDT

Currently, they are copied by a script phase that runs `ditto`. This can’t be properly incrementalized, because Xcode doesn’t know which files are being copied. In its current state, it causes WebKit’s module verifier to re-run spuriously, even though there are no resources being copied.

Attachments
Add attachment proposed patch, testcase, etc.

Elliott Williams

Comment 1 2023-09-06 16:27:07 PDT

<rdar://problem/115082280>

Elliott Williams

Comment 2 2023-09-06 17:29:57 PDT

Pull request: https://github.com/WebKit/WebKit/pull/17520

EWS

Comment 3 2023-09-07 14:00:34 PDT

Committed 267747@main (a5cc5d4900a0): <https://commits.webkit.org/267747@main> Reviewed commits have been landed. Closing PR #17520 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.