Bug 261247

Summary:	[Xcode] Track output files for symlinks created by WebKit script phases
Product:	WebKit	Reporter:	Elliott Williams <emw>
Component:	Tools / Tests	Assignee:	Elliott Williams <emw>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	commit-queue, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	261333, 261379
Bug Blocks:

Elliott Williams

Reported 2023-09-06 17:52:28 PDT

WebKit's "Create Symlinks to..." script phases currently list no dependencies, so they re-run spuriously and cause the module verifier to re-run as well. Add output paths for these tasks.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-09-06 17:52:42 PDT

<rdar://problem/115085679>

Elliott Williams

Comment 2 2023-09-07 10:59:59 PDT

Pull request: https://github.com/WebKit/WebKit/pull/17548

EWS

Comment 3 2023-09-07 13:53:26 PDT

Committed 267746@main (cdc9a148a8b4): <https://commits.webkit.org/267746@main> Reviewed commits have been landed. Closing PR #17548 and removing active labels.

WebKit Commit Bot

Comment 4 2023-09-08 07:37:25 PDT

Re-opened since this is blocked by bug 261333

EWS

Comment 5 2023-09-08 15:58:40 PDT

Committed 267813@main (45daf39b3172): <https://commits.webkit.org/267813@main> Reviewed commits have been landed. Closing PR #17611 and removing active labels.

WebKit Commit Bot

Comment 6 2023-09-09 17:53:58 PDT

Re-opened since this is blocked by bug 261379

Elliott Williams

Comment 7 2023-09-12 22:27:16 PDT

Pull request: https://github.com/WebKit/WebKit/pull/17724

EWS

Comment 8 2023-09-14 11:22:36 PDT

Committed 267999@main (633de901b818): <https://commits.webkit.org/267999@main> Reviewed commits have been landed. Closing PR #17724 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.