Bug 261415

Summary: downcast() should return a smart pointer when passed in a smart pointer
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Chris Dumez
Reported 2023-09-11 10:01:06 PDT
downcast() should return a smart pointer when passed in a smart pointer. Otherwise, it forces us to use the less-safe static_pointer_cast() / static_reference_cast() to cast without causing ref counting churn.
Attachments
Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2023-09-11 10:09:44 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17655
EWS
Comment 2 2023-09-12 15:37:19 PDT
Committed 267923@main (cea23dc5de28): <https://commits.webkit.org/267923@main> Reviewed commits have been landed. Closing PR #17655 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-09-12 15:38:13 PDT
<rdar://problem/115391755>
Note You need to log in before you can comment on or make changes to this bug.