| Summary: | AX ITM: Not necessary to cache IsFocused in isolated objects. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||
| Component: | Accessibility | Assignee: | Andres Gonzalez <andresg_22> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Andres Gonzalez
2023-09-11 14:03:00 PDT
Created attachment 467647 [details]
Patch
Comment on attachment 467647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467647&action=review > COMMIT_MESSAGE:7 > +Instead of caching this property and updating it, this patch changes the implementation of AXIsolatedObject::isFocused() to use the tree's focused object ID. this guaranties consistency between the methods isFocuse() and focusedUIElement, i.e., isFocused() will return true if and only if the object is the unique focus. > this guaranties this should probably be capitalized, and guaranties looks like a typo. isFocuse() is another likely typo. Created attachment 467658 [details]
Patch
Committed 267901@main (435613e4bde1): <https://commits.webkit.org/267901@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467658 [details]. |