Bug 261455

Summary: [IFC][Cleanup] canUseForStyle only checks block level style
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
[fast-cq]Patch none

Description zalan 2023-09-11 20:26:31 PDT
rename it to canUseForBlockStyle
Comment 1 zalan 2023-09-11 20:33:15 PDT
Created attachment 467656 [details]
Patch
Comment 2 Antti Koivisto 2023-09-12 06:24:03 PDT
Comment on attachment 467656 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467656&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:266
> +static OptionSet<AvoidanceReason> canUseForBlockStyle(const RenderElement& blockContainer, IncludeReasons includeReasons)

Could be RenderBlockFlow&
Comment 3 zalan 2023-09-12 06:42:12 PDT
Created attachment 467660 [details]
Patch
Comment 4 zalan 2023-09-12 06:57:16 PDT
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 467656 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467656&action=review
> 
> > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:266
> > +static OptionSet<AvoidanceReason> canUseForBlockStyle(const RenderElement& blockContainer, IncludeReasons includeReasons)
> 
> Could be RenderBlockFlow&
good point!
Comment 5 zalan 2023-09-12 07:14:47 PDT
Created attachment 467662 [details]
[fast-cq]Patch
Comment 6 EWS 2023-09-12 07:50:42 PDT
Committed 267902@main (7496adff3156): <https://commits.webkit.org/267902@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467662 [details].
Comment 7 Radar WebKit Bug Importer 2023-09-12 07:51:13 PDT
<rdar://problem/115356083>