| Summary: | [WebCrypto] Refactoring: Add checks for supported algorithms | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Javier Fernandez <jfernandez> |
| Component: | WebCore Misc. | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
Javier Fernandez
2023-09-14 00:54:30 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17768 Committed 268079@main (1fa83f2bc4ee): <https://commits.webkit.org/268079@main> Reviewed commits have been landed. Closing PR #17768 and removing active labels. Debian Stable and Ubuntu 20.04 build bots are failing after this patch with the following error: https://build.webkit.org/#/builders/595/builds/13369 ``` In file included from /home/buildbot/worker/GTK-Linux-64-bit-Release-Ubuntu-2004-Build/build/WebKitBuild/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-44a97133-6.cpp:4: /home/buildbot/worker/GTK-Linux-64-bit-Release-Ubuntu-2004-Build/build/Source/WebCore/crypto/gcrypt/CryptoKeyOKPGCrypt.cpp: In function ‘const std::array<unsigned char, 12> WebCore::algorithmId(WebCore::CryptoKeyOKP::NamedCurve)’: /home/buildbot/worker/GTK-Linux-64-bit-Release-Ubuntu-2004-Build/build/Source/WebCore/crypto/gcrypt/CryptoKeyOKPGCrypt.cpp:260:25: error: could not convert ‘{{""}}’ from ‘<brace-enclosed initializer list>’ to ‘const std::array<unsigned char, 12>’ 260 | return { { "" } }; | ^ | | | <brace-enclosed initializer list> ninja: build stopped: subcommand failed. ``` Re-opening for pull request https://github.com/webkit/webkit/pull/17917 Committed 268126@main (0d052d134bf0): <https://commits.webkit.org/268126@main> Reviewed commits have been landed. Closing PR #17917 and removing active labels. |