Bug 261569

Summary:	[ews] compile-webkit step should fail builds that exceed a predefined threshold of log lines
Product:	WebKit	Reporter:	Aakash Jain <aakash_jain>
Component:	Tools / Tests	Assignee:	Aakash Jain <aakash_jain>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aakash_jain, jbedard, ryanhaddad, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=249054 https://bugs.webkit.org/show_bug.cgi?id=261614

Description Aakash Jain 2023-09-14 13:34:10 PDT

[ews] compile-webkit step should fail builds that exceed a predefined threshold of log lines. This can cause buildbot to grind to a halt as it cannot handle the memory / database load.

(This is a subtask of https://bugs.webkit.org/show_bug.cgi?id=249054)

Comment 1 Aakash Jain 2023-09-14 13:43:23 PDT

One example (though on build.webkit.org) was on 2022-04-08 when the buildbot server was extremely slow and returning 502. The cause was huge logging, 
e.g.: 1 million log lines in compile-webkit step in https://build.webkit.org/#/builders/375/builds/3955

Comment 2 Aakash Jain 2023-09-14 14:03:15 PDT

Pull request: https://github.com/WebKit/WebKit/pull/17782

Comment 3 EWS 2023-09-15 04:43:13 PDT

Committed 268017@main (9d2c662836f4): <https://commits.webkit.org/268017@main>

Reviewed commits have been landed. Closing PR #17782 and removing active labels.

Comment 4 Radar WebKit Bug Importer 2023-09-15 04:44:14 PDT

<rdar://problem/115549995>