Bug 261614

Summary:	[build.webkit.org] compile-webkit step should fail builds that exceed a predefined threshold of log lines
Product:	WebKit	Reporter:	Aakash Jain <aakash_jain>
Component:	Tools / Tests	Assignee:	Aakash Jain <aakash_jain>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aakash_jain, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=249054 https://bugs.webkit.org/show_bug.cgi?id=261569

Description Aakash Jain 2023-09-15 11:49:10 PDT

Similar to https://bugs.webkit.org/show_bug.cgi?id=261569, for build.webkit.org also, compile-webkit step should fail builds that exceed a predefined threshold of log lines. This can cause buildbot to grind to a halt as it cannot handle the memory / database load.

(This is a subtask of https://bugs.webkit.org/show_bug.cgi?id=249054)

One example was on 2022-04-08 when the buildbot server was extremely slow and returning 502. The cause was huge logging, 
e.g.: 1 million log lines in compile-webkit step in https://build.webkit.org/#/builders/375/builds/3955

Comment 1 Aakash Jain 2023-09-15 11:53:38 PDT

Pull request: https://github.com/WebKit/WebKit/pull/17820

Comment 2 EWS 2023-09-15 13:07:28 PDT

Committed 268034@main (e6adefb9e862): <https://commits.webkit.org/268034@main>

Reviewed commits have been landed. Closing PR #17820 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2023-09-15 13:08:20 PDT

<rdar://problem/115569226>