Bug 261630

Summary:	Avoid computing layer bounds in BackingSharingState::isAdditionalProviderCandidate()
Product:	WebKit	Reporter:	Simon Fraser (smfr) <simon.fraser>
Component:	Compositing	Assignee:	Simon Fraser (smfr) <simon.fraser>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	koivisto, simon.fraser, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified

Simon Fraser (smfr)

Reported 2023-09-15 19:50:33 PDT

The calls to calculateLayerBounds() in BackingSharingState::isAdditionalProviderCandidate() show as very hot on profiles on a page with many (thousands) of backing sharing candidates. We have already computed layer bounds, so we can just use the ones we've computed in OverlapExtent.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-09-15 19:51:04 PDT

<rdar://problem/115584910>

Simon Fraser (smfr)

Comment 2 2023-09-15 20:00:44 PDT

Pull request: https://github.com/WebKit/WebKit/pull/17834

EWS

Comment 3 2023-09-16 12:47:57 PDT

Committed 268056@main (9dcbb2227753): <https://commits.webkit.org/268056@main> Reviewed commits have been landed. Closing PR #17834 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.