Bug 261637
| Summary: | [GTK] build breaks with -DUSE_GBM=OFF: WebCore/DMABufFormat.h: No such file or directory | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jim Mason <jmason> |
| Component: | WebKitGTK | Assignee: | Carlos Garcia Campos <cgarcia> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, thomas.devoogdt |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jim Mason
building 2.42.0 (tarball)
-DUSE_GBM=OFF
Unguarded inclusion of a GBM-related header breaks compilation of two source files:
webkitgtk-2.42.0/Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp:36:10: fatal error: WebCore/DMABufFormat.h: No such file or directory
36 | #include <WebCore/DMABufFormat.h>
webkitgtk-2.42.0/Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.cpp:34:10: fatal error: WebCore/DMABufFormat.h: No such file or directory
34 | #include <WebCore/DMABufFormat.h>
Both source files reference one constant from DMABufFormat.h, `WebCore::DMABufFormat::Modifier::Invalid`
Build completes normally when the header file and test involving the constant are removed from the source files.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/17854
EWS
Committed 268112@main (ba13698c64e0): <https://commits.webkit.org/268112@main>
Reviewed commits have been landed. Closing PR #17854 and removing active labels.
Thomas Devoogdt
There is more here, also #include <epoxy/egl.h> is not a given if USE_OPENGL_OR_ES=OFF and USE_GBM=OFF.
webkitgtk-2.42.0/Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp:39:10: fatal error: epoxy/egl.h: No such file or directory
39 | #include <epoxy/egl.h>
| ^~~~~~~~~~~~~
Carlos Garcia Campos
(In reply to Thomas Devoogdt from comment #3)
> There is more here, also #include <epoxy/egl.h> is not a given if
> USE_OPENGL_OR_ES=OFF and USE_GBM=OFF.
>
>
> webkitgtk-2.42.0/Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.
> cpp:39:10: fatal error: epoxy/egl.h: No such file or directory
> 39 | #include <epoxy/egl.h>
> | ^~~~~~~~~~~~~
That's because of USE_OPENGL_OR_ES not GBM. File a new bug report, please.
Thomas Devoogdt
New bug report: https://bugs.webkit.org/show_bug.cgi?id=262169.