Bug 261646

Summary: AX: Computed role of role="form" and role="region" elements does not dynamically update when label changes
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tyler Wilcock
Reported 2023-09-16 19:01:12 PDT
...
Attachments
Patch (8.75 KB, patch)
2023-09-16 19:06 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (8.81 KB, patch)
2023-09-17 10:53 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (8.80 KB, patch)
2023-09-18 00:18 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-09-16 19:01:26 PDT
<rdar://problem/115608740>
Tyler Wilcock
Comment 2 2023-09-16 19:06:06 PDT
Created attachment 467709 [details] Patch
Tyler Wilcock
Comment 3 2023-09-17 10:53:54 PDT
Created attachment 467722 [details] Patch
chris fleizach
Comment 4 2023-09-17 22:32:14 PDT
Comment on attachment 467722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467722&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:2459 > + RefPtr axObject = getOrCreate(element); do we need to create an object here, or is just getting an existing one sufficient, since other creation methods will get the right value?
Tyler Wilcock
Comment 5 2023-09-18 00:18:41 PDT
Created attachment 467736 [details] Patch
Tyler Wilcock
Comment 6 2023-09-18 00:18:56 PDT
(In reply to chris fleizach from comment #4) > Comment on attachment 467722 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=467722&action=review > > > Source/WebCore/accessibility/AXObjectCache.cpp:2459 > > + RefPtr axObject = getOrCreate(element); > > do we need to create an object here, or is just getting an existing one > sufficient, since other creation methods will get the right value? Good catch!
EWS
Comment 7 2023-09-18 11:00:10 PDT
Committed 268087@main (bc6b70cc4367): <https://commits.webkit.org/268087@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467736 [details].
Note You need to log in before you can comment on or make changes to this bug.