| Summary: | AX: Computed role of role="form" and role="region" elements does not dynamically update when label changes | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tyler Wilcock <tyler_w> | ||||||||
| Component: | Accessibility | Assignee: | Tyler Wilcock <tyler_w> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Other | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Tyler Wilcock
2023-09-16 19:01:12 PDT
Created attachment 467709 [details]
Patch
Created attachment 467722 [details]
Patch
Comment on attachment 467722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467722&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:2459 > + RefPtr axObject = getOrCreate(element); do we need to create an object here, or is just getting an existing one sufficient, since other creation methods will get the right value? Created attachment 467736 [details]
Patch
(In reply to chris fleizach from comment #4) > Comment on attachment 467722 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=467722&action=review > > > Source/WebCore/accessibility/AXObjectCache.cpp:2459 > > + RefPtr axObject = getOrCreate(element); > > do we need to create an object here, or is just getting an existing one > sufficient, since other creation methods will get the right value? Good catch! Committed 268087@main (bc6b70cc4367): <https://commits.webkit.org/268087@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467736 [details]. |