Bug 261709

Summary:	[PGO] GPUP's executable should not be built for instrumentation
Product:	WebKit	Reporter:	Elliott Williams <emw>
Component:	Tools / Tests	Assignee:	Elliott Williams <emw>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Elliott Williams

Reported 2023-09-18 16:33:33 PDT

Like other XPC services, its use of the WebKit frameworks should be instrumented, but not its main executable. It is missing the CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING build setting that other targets have.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-09-18 16:34:09 PDT

<rdar://problem/115688644>

Elliott Williams

Comment 2 2023-09-18 16:37:34 PDT

Pull request: https://github.com/WebKit/WebKit/pull/17885

EWS

Comment 3 2023-09-19 17:09:24 PDT

Committed 268164@main (f35c6c8e306f): <https://commits.webkit.org/268164@main> Reviewed commits have been landed. Closing PR #17885 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.