Bug 261742

Summary: AX: Add AXCorObject.cpp and move methods implementation from AccessibilityObjectInterface.h.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, annulen, apinheiro, cfleizach, dmazzoni, ews-watchlist, gyuyoung.kim, hi, jcraig, jdiggs, joepeck, pangle, ryuan.choi, samuel_white, sergio, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Andres Gonzalez 2023-09-19 07:41:17 PDT
.
Comment 1 Radar WebKit Bug Importer 2023-09-19 07:41:27 PDT
<rdar://problem/115725555>
Comment 2 Andres Gonzalez 2023-09-19 19:06:34 PDT
Created attachment 467774 [details]
Patch
Comment 3 Andres Gonzalez 2023-09-20 10:54:39 PDT
Created attachment 467789 [details]
Patch
Comment 4 Andres Gonzalez 2023-09-20 11:26:02 PDT
Created attachment 467790 [details]
Patch
Comment 5 Tyler Wilcock 2023-09-20 13:05:23 PDT
Comment on attachment 467790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467790&action=review

> Source/WebCore/accessibility/AXCoreObject.cpp:119
> +        // These roles are containers whose children support aria-selected:

Seems like this comment got indented an extra level as part of the move.

> Source/WebCore/accessibility/AXCoreObject.cpp:128
> +        // These roles are containers whose children are treated as selected by assistive
> +        // technologies. We can get the "selected" item via aria-activedescendant or the
> +        // focused element.

Seems like this comment got indented an extra level as part of the move.
Comment 6 Andres Gonzalez 2023-09-20 13:24:23 PDT
Created attachment 467793 [details]
Patch

Fixed indentation of comments.
Comment 7 EWS 2023-09-20 14:55:22 PDT
Committed 268217@main (bcba489ee356): <https://commits.webkit.org/268217@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467793 [details].