Bug 261756

Summary:	enclosingClippingScopes() can be called twice per layer on compositing updates
Product:	WebKit	Reporter:	Simon Fraser (smfr) <simon.fraser>
Component:	Compositing	Assignee:	Simon Fraser (smfr) <simon.fraser>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	simon.fraser, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified

Simon Fraser (smfr)

Reported 2023-09-19 10:36:30 PDT

enclosingClippingScopes() does an ancestor tree walk, and shows up in profiles on layer-heavy sites. It's called from both layerOverlaps() and addToOverlapMap(), so we can avoid one of those calls.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-09-19 10:36:53 PDT

<rdar://problem/115734407>

Simon Fraser (smfr)

Comment 2 2023-09-19 10:41:09 PDT

Pull request: https://github.com/WebKit/WebKit/pull/17924

EWS

Comment 3 2023-09-19 21:02:36 PDT

Committed 268176@main (6d84ae083179): <https://commits.webkit.org/268176@main> Reviewed commits have been landed. Closing PR #17924 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.