Bug 261900

Summary:

[IFC][Ruby] Implement overhangForAnnotationBefore/overhangForAnnotationAfter

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
[fast-cq]Patch	none

Description zalan 2023-09-21 12:26:17 PDT

ssia

Comment 1 zalan 2023-09-21 12:34:16 PDT

Created attachment 467817 [details]
Patch

Comment 2 Antti Koivisto 2023-09-22 01:48:15 PDT

Comment on attachment 467817 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467817&action=review

> Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:157
> +    if (!annotationBox || rubyBaseContentEndIndex == boxes.size() -1)

space missing after -

Comment 3 zalan 2023-09-22 13:35:55 PDT

Created attachment 467828 [details]
[fast-cq]Patch

Comment 4 EWS 2023-09-22 19:33:23 PDT

Committed 268351@main (867fce02ad07): <https://commits.webkit.org/268351@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467828 [details].

Comment 5 Radar WebKit Bug Importer 2023-09-22 19:34:13 PDT

<rdar://problem/115920408>