| Summary: | [Win] REGRESSION(268343@main): Crash under WebCore::PositionedDescendantsMap::removeContainingBlock | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> |
| Component: | WebCore Misc. | Assignee: | Fujii Hironori <Hironori.Fujii> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
Fujii Hironori
2023-09-23 05:49:59 PDT
268343@main (bug#261545) is the culprit? I bisected and confirmed it happened after 268343@main. Are you able to figure out which CheckedPtr is causing this? It will be hard for me without reproducing. Then I guess we can revert that particular CheckedPtr for now or switch to a WeakPtr. In removeContainingBlock, renderer doesn't seem to be a valid object. https://github.com/WebKit/WebKit/blob/8aa2481bf186536ad7a85d228abc51f42c53a321/Source/WebCore/rendering/RenderBlock.cpp#L222 In the previous code, it is no problem because the code just removes a raw pointer from m_containerMap. Pull request: https://github.com/WebKit/WebKit/pull/18126 Committed 268373@main (e9f67fe4c9c1): <https://commits.webkit.org/268373@main> Reviewed commits have been landed. Closing PR #18126 and removing active labels. |