Bug 262016

Summary: REGRESSION(268368@main): causes an assertion failure for http tests
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, Hironori.Fujii, kohei.ueno119, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 261671    
Attachments:
Description Flags
REVERT of 268368@main Hironori.Fujii: commit-queue+

Description WebKit Commit Bot 2023-09-24 13:43:07 PDT
https://commits.webkit.org/268368@main introduced a regression:
causes an assertion failure for http tests

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2023-09-24 13:43:14 PDT
Created attachment 467843 [details]
REVERT of 268368@main

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Fujii Hironori 2023-09-24 13:54:24 PDT
Oh, no.

> error: patch failed: LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/newlines.vtt:1
> error: LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/newlines.vtt: patch does not apply
Comment 3 Fujii Hironori 2023-09-24 14:08:10 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18135
Comment 4 Kueno 2023-09-24 15:55:30 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18139
Comment 5 EWS 2023-09-24 16:20:27 PDT
Committed 268377@main (aa8ce99efeea): <https://commits.webkit.org/268377@main>

Reviewed commits have been landed. Closing PR #18135 and removing active labels.
Comment 6 Radar WebKit Bug Importer 2023-09-24 16:21:14 PDT
<rdar://problem/115966306>