Bug 262135
| Summary: | [WGSL] Buffer dynamic offsets are not implemented | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Wyrzykowski <mwyrzykowski> |
| Component: | WebGPU | Assignee: | Tadeu Zagallo <tzagallo> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mike Wyrzykowski
[WGSL] Buffer dynamic offsets are not implemented
This offset would probably be in its own buffer because the pipeline doesn't know the value until right before draw time.
So:
[[vertex]] type2 function0(type3 parameter0 [[stage_in]], constant type5& parameter1 [[buffer(22)]])
{
const constant type4& local0 = parameter1.uniforms;
would become something like:
[[vertex]] type2 function0(type3 parameter0 [[stage_in]], constant type5& parameter1 [[buffer(22)]], constant uint32_t* offsets [[buffer(23)]])
{
const constant type4& local0 = *(const constant type4*)((constant char*)¶meter1.uniforms + offsets[INDEX]));
where INDEX is 0,1,2... corresponding to the nth buffer in the bind group
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/116073820>
Tadeu Zagallo
Pull request: https://github.com/WebKit/WebKit/pull/18992
EWS
Committed 269418@main (7990584a04b5): <https://commits.webkit.org/269418@main>
Reviewed commits have been landed. Closing PR #18992 and removing active labels.