Bug 262164

Summary:	[commits.webkit.org] Ignore requests for invalid refs
Product:	WebKit	Reporter:	Jonathan Bedard <jbedard>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Jonathan Bedard

Reported 2023-09-26 21:09:03 PDT

There is a relatively narrow set of valid references commits.webkit.org will be able to resolve to actual commits. Although we can always check a reference against commits.webkit.org's checkout, that's relatively expensive. We should just early exit if a requested ref is an obviously invalid string.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-09-26 21:09:40 PDT

<rdar://problem/116099852>

Jonathan Bedard

Comment 2 2023-09-27 10:45:21 PDT

Pull request: https://github.com/WebKit/WebKit/pull/18291

EWS

Comment 3 2023-09-27 10:59:49 PDT

Committed 268522@main (0441827bd96f): <https://commits.webkit.org/268522@main> Reviewed commits have been landed. Closing PR #18291 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.