Bug 262230

Summary: [visionOS] Sign in with Apple window not anchored to the host app
Product: WebKit Reporter: Ryan Fuller <ryanfuller>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ryanfuller, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 17   
Hardware: Vision Pro   
OS: visionOS 1   

Ryan Fuller
Reported 2023-09-27 17:37:29 PDT
The SiwA sheet is presented in unexpected places from a bincompat app using web authentication. This is due to an incorrect bundle identifier, but the preferred method is specifying a scene identifier to anchor to. AuthKit has made changes to accept a callerSceneIndetifier from the auth request (ASAuthorizationProviderExtensionAuthorizationRequest). So we need to return the correct sceneID. WebKit (in SOAuthorizationSession) is responsible for firing off the request, which is actually an SOAuthorizationRequest. Later, AuthKit wraps this request in the AS..AuthorizationRequest.
Attachments
Ryan Fuller
Comment 1 2023-09-27 17:41:25 PDT
Ryan Fuller
Comment 2 2023-09-27 18:11:36 PDT
Ryan Fuller
Comment 3 2023-09-27 19:02:46 PDT
Ryan Fuller
Comment 4 2023-09-27 19:04:25 PDT
(In reply to Ryan Fuller from comment #2) > Pull request: https://github.com/WebKit/WebKit/pull/18321 This was declined, please see: https://github.com/WebKit/WebKit/pull/18323
EWS
Comment 5 2023-09-28 14:58:35 PDT
Committed 268613@main (5af55e89b234): <https://commits.webkit.org/268613@main> Reviewed commits have been landed. Closing PR #18323 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.