Bug 262262

I will upload the minimized testcase as soon as possible.

<rdar://problem/116503519>

Hello, I would like to ask if a previously submitted bug is still not processed or unconfirmed, was it submitted in the wrong way? Or is it something else? Should I offer more info?

Created attachment 470282 [details]
testcase trimmed

Sorry for uploading the trimmed testcase so late.
Hope it cloud help.

(In reply to djinn from comment #4)
> Created attachment 470282 [details]
> testcase trimmed
> 
> Sorry for uploading the trimmed testcase so late.
> Hope it cloud help.
It does help, thank you! Will look into this shortly.

(In reply to zalan from comment #5)
> (In reply to djinn from comment #4)
> > Created attachment 470282 [details]
> > testcase trimmed
> > 
> > Sorry for uploading the trimmed testcase so late.
> > Hope it cloud help.
> It does help, thank you! Will look into this shortly.
I can't seem to reproduce this anymore on tip of tree Webkit.

Created attachment 470318 [details]
crash message

(In reply to djinn from comment #0)
> Created attachment 467936 [details]
> testcase to trigger the crash
> 
> ASSERTION FAILED: displayLine.lineBoxLogicalRect().x() +
> displayLine.contentLogicalLeft() + displayLine.contentLogicalWidth() +
> ellipsisWidth > displayLine.lineBoxLogicalRect().maxX()
> /app/webkit/Source/WebCore/layout/formattingContexts/inline/display/
> InlineDisplayLineBuilder.cpp(230) : float
> WebCore::Layout::truncateOverflowingDisplayBoxes(const
> WebCore::InlineDisplay::Line&, WebCore::InlineDisplay::Boxes&, float, const
> WebCore::RenderStyle&, LineEndingEllipsisPolicy)

So sorry for uploading wrong crashed message before. I've reproduce several times. And the crashed message should be:
ASSERTION FAILED: lineEndingEllipsisPolicy != LineEndingEllipsisPolicy::WhenContentOverflowsInInlineDirection || truncateRight.has_value() || right(boxes.last()) == visualRightForContentEnd
/app/webkit/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp(260) : float WebCore::Layout::truncateOverflowingDisplayBoxes(const WebCore::InlineDisplay::Line&, WebCore::InlineDisplay::Boxes&, float, const WebCore::RenderStyle&, LineEndingEllipsisPolicy)

And the minimized testcase could trigger the crash within minutes.

(In reply to djinn from comment #8)
> (In reply to djinn from comment #0)
> > Created attachment 467936 [details]
> > testcase to trigger the crash
> > 
> > ASSERTION FAILED: displayLine.lineBoxLogicalRect().x() +
> > displayLine.contentLogicalLeft() + displayLine.contentLogicalWidth() +
> > ellipsisWidth > displayLine.lineBoxLogicalRect().maxX()
> > /app/webkit/Source/WebCore/layout/formattingContexts/inline/display/
> > InlineDisplayLineBuilder.cpp(230) : float
> > WebCore::Layout::truncateOverflowingDisplayBoxes(const
> > WebCore::InlineDisplay::Line&, WebCore::InlineDisplay::Boxes&, float, const
> > WebCore::RenderStyle&, LineEndingEllipsisPolicy)
> 
> So sorry for uploading wrong crashed message before. I've reproduce several
> times. And the crashed message should be:
> ASSERTION FAILED: lineEndingEllipsisPolicy !=
> LineEndingEllipsisPolicy::WhenContentOverflowsInInlineDirection ||
> truncateRight.has_value() || right(boxes.last()) == visualRightForContentEnd
> /app/webkit/Source/WebCore/layout/formattingContexts/inline/display/
> InlineDisplayLineBuilder.cpp(260) : float
> WebCore::Layout::truncateOverflowingDisplayBoxes(const
> WebCore::InlineDisplay::Line&, WebCore::InlineDisplay::Boxes&, float, const
> WebCore::RenderStyle&, LineEndingEllipsisPolicy)
> 
> And the minimized testcase could trigger the crash within minutes.
Oh right, it indeed takes a while (I incorrectly assumed an instant crash). Thank you!

Created attachment 470356 [details]
Test reduction

Created attachment 470358 [details]
[fast-cq]Patch

Committed 276089@main (f7185dc48501): <https://commits.webkit.org/276089@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 470358 [details].