Bug 262371

Summary:	[build.webkit.org] download-built-product step fails on uat instances
Product:	WebKit	Reporter:	Aakash Jain <aakash_jain>
Component:	Tools / Tests	Assignee:	Aakash Jain <aakash_jain>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aakash_jain, jbedard, ryanhaddad, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=256799

Description Aakash Jain 2023-09-29 08:07:56 PDT

[build.webkit.org] download-built-product step fails on uat instances.

e.g.: http://build.webkit-uat.org/#/builders/759/builds/2


Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/twisted/internet/defer.py", line 1445, in _inlineCallbacks
    result = current_context.run(g.send, result)
  File "/usr/local/lib/python3.9/site-packages/buildbot/process/buildstep.py", line 628, in startStep
    self.results = yield self.run()
  File "/usr/local/lib/python3.9/site-packages/twisted/internet/defer.py", line 1656, in unwindGenerator
    return _cancellableInlineCallbacks(gen)
  File "/usr/local/lib/python3.9/site-packages/twisted/internet/defer.py", line 1571, in _cancellableInlineCallbacks
    _inlineCallbacks(None, g, status)
--- <exception caught here> ---
  File "/usr/local/lib/python3.9/site-packages/buildbot/process/buildstep.py", line 628, in startStep
    self.results = yield self.run()
  File "/usr/local/lib/python3.9/site-packages/twisted/internet/defer.py", line 1445, in _inlineCallbacks
    result = current_context.run(g.send, result)
  File "/var/buildbot/OpenSource/Tools/CISupport/build-webkit-org/steps.py", line 575, in run
    self.finished(SKIPPED)
  File "/usr/local/lib/python3.9/site-packages/buildbot/process/buildstep.py", line 817, in finished
    assert self._start_deferred, \
builtins.AttributeError: 'DownloadBuiltProduct' object has no attribute '_start_deferred'

Comment 1 Aakash Jain 2023-09-29 08:12:15 PDT

"finished() can only be called from old steps implementing start()".

Fallout from: https://bugs.webkit.org/show_bug.cgi?id=256799 [build.webkit.org] Replace shell.ShellCommand with new-style

Comment 2 Aakash Jain 2023-09-29 08:15:13 PDT

Pull request: https://github.com/WebKit/WebKit/pull/18413

Comment 3 EWS 2023-09-29 09:18:56 PDT

Committed 268652@main (a4c5c55d46c1): <https://commits.webkit.org/268652@main>

Reviewed commits have been landed. Closing PR #18413 and removing active labels.

Comment 4 Radar WebKit Bug Importer 2023-09-29 09:19:16 PDT

<rdar://problem/116240754>