| Summary: | [IFC][Cleanup] InlineFormattingContext should construct/own InlineLayoutState | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
zalan
2023-09-29 15:52:55 PDT
Created attachment 467981 [details]
Patch
Created attachment 467986 [details]
Patch
Created attachment 467987 [details]
Patch
Comment on attachment 467987 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467987&action=review nice! > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:771 > + if (auto adjustedRect = InlineFormattingQuirks::adjustedRectForLineGridLineAlign(constraints.logicalRect, formattingContext().root().style(), inlineLayoutState())) > constraints.logicalRect = *adjustedRect; adjustedRectForLineGridLineAlign can now be turned non-static and called via formattingContext().formattingQuirks(). Then it will only need the constraints.logicalRect parameter. (In reply to Antti Koivisto from comment #4) > Comment on attachment 467987 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=467987&action=review > > nice! > > > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:771 > > + if (auto adjustedRect = InlineFormattingQuirks::adjustedRectForLineGridLineAlign(constraints.logicalRect, formattingContext().root().style(), inlineLayoutState())) > > constraints.logicalRect = *adjustedRect; > > adjustedRectForLineGridLineAlign can now be turned non-static and called via > formattingContext().formattingQuirks(). Then it will only need the > constraints.logicalRect parameter. good point! Created attachment 468003 [details]
[fast-cq]Patch
Committed 268703@main (8ac5e0757320): <https://commits.webkit.org/268703@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 468003 [details]. |