Bug 262472

Summary:	[Curl] Reduce unnecessary data conversions
Product:	WebKit	Reporter:	Kenji Shukuwa <kenji.shukuwa>
Component:	Platform	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	Hironori.Fujii, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Kenji Shukuwa 2023-10-01 23:36:22 PDT

Currently, a SharedBuffer is generated in CurlRequest::didReceiveDataCallback when receiving data
from libcurl. However, if CurlRequest::didReceiveData performs CURL_WRITEFUNC_PAUSE processing,
this SharedBuffer will be discarded without being used.

Also, CurlMultipartHandle::didReceiveMessage performs a SharedBuffer to Vector conversion.
This is a wasteful data conversion.

For this reason, avoid converting to SharedBuffer at the time of CurlRequest::didReceiveDataCallback.

Comment 1 Kenji Shukuwa 2023-10-01 23:58:49 PDT

Pull request: https://github.com/WebKit/WebKit/pull/18486

Comment 2 EWS 2023-10-03 13:18:03 PDT

Committed 268801@main (7ab6aab9c1b7): <https://commits.webkit.org/268801@main>

Reviewed commits have been landed. Closing PR #18486 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2023-10-03 13:19:16 PDT

<rdar://problem/116418404>